reschke commented on code in PR #2454:
URL: https://github.com/apache/jackrabbit-oak/pull/2454#discussion_r2284005727
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/concurrent/package-info.java:
##########
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-@Version("1.0.1")
+@Version("1.1.0")
Review Comment:
Please do not put new methods into public APIs unless they are really needed
outside Oak. In the past we created new packages for that.
See https://github.com/apache/jackrabbit-oak/pull/2457 which happens to do
that.
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/concurrent/ForkJoinUtils.java:
##########
@@ -0,0 +1,120 @@
+/*
Review Comment:
There should be unit test coverage inside oak-commons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
