mkapalka commented on code in PR #2469:
URL: https://github.com/apache/jackrabbit-oak/pull/2469#discussion_r2297448091
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/ClusterNodeStoreLock.java:
##########
@@ -38,10 +38,14 @@
*/
public class ClusterNodeStoreLock implements
AsyncIndexerLock<ClusteredLockToken> {
/**
- * Use a looong lease time to ensure that async indexer does not start
- * in between the import process which can take some time
+ * Use a long lease time to ensure that async indexer does not start
+ * in between the import process which can take some time.
+ * For a very large repository (about 2 billion nodes) the longest
+ * index import can take 2.5 hours. 6 hours has then a safety margin of
100%
+ * above that. A diff of 6 hours is typically OK with the document node
store,
+ * but beyond that it gets harder.
*/
- private static final long LOCK_TIMEOUT = TimeUnit.DAYS.toMillis(100);
+ private static final long LOCK_TIMEOUT = TimeUnit.HOURS.toMillis(6);
Review Comment:
How about making this configurable (but still change the default) so that
one can quickly override this if it causes issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
