mreutegg commented on code in PR #2480:
URL: https://github.com/apache/jackrabbit-oak/pull/2480#discussion_r2306392742


##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/v8/AzurePersistenceV8.java:
##########
@@ -154,4 +155,9 @@ public CloudBlobDirectory getSegmentstoreDirectory() {
     public void setWriteAccessController(WriteAccessController 
writeAccessController) {
         this.writeAccessController = writeAccessController;
     }
+
+    @TestOnly
+    void disableWriting() {
+        writeAccessController.disableWriting();
+    }

Review Comment:
   I would rather not introduce this method. `AzureArchiveManagerV8Test` 
creates a `WriteAccessController` and passes it to `AzurePersistenceV8`. I 
think if the test class had a `WriteAccessController` field, 
`testListArchiveWithDeleteMarkerPresentAndNoWriteAccess()` could disable writes 
on the `WriteAccessController` instead of `AzurePersistenceV8`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to