reschke commented on code in PR #2511:
URL: https://github.com/apache/jackrabbit-oak/pull/2511#discussion_r2372676879
##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/EventFactory.java:
##########
@@ -298,6 +334,17 @@ public boolean isExternal() {
//--------------------------------------------------------< Object >--
+ /** A custom version of getInfo(), which is only used
+ * for the toString() implementation; the goal is to limit the amount
+ * of data, which is returned, no binary data should be logged
Review Comment:
```suggestion
* of data that is returned; no binary data should be logged.
```
##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/EventFactory.java:
##########
@@ -101,6 +103,17 @@ public int getType() {
builder.put("afterValue", createValue(after));
return Collections.unmodifiableMap(builder);
}
+ @Override
+ public Map<?,?> getInfo_ToString() {
Review Comment:
I was wondering whether we can make all these maps String-keyd; but maybe
that would be a different ticket. (see Sonar warnings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
