rishabhdaim commented on code in PR #2573:
URL: https://github.com/apache/jackrabbit-oak/pull/2573#discussion_r2426195400
##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/binary/fixtures/nodestore/DocumentMemoryNodeStoreFixture.java:
##########
@@ -87,11 +86,11 @@ public NodeStore createNodeStore() {
// track all main components
if (dataStore != null) {
- components.put(nodeStore, DataStore.class.getName(),
dataStore);
- components.put(nodeStore, DataStore.class.getName() +
":folder", dataStoreFolder);
+ components.computeIfAbsent(nodeStore, k -> new
LinkedHashMap<>()).put(DataStore.class.getName(), dataStore);
+ components.computeIfAbsent(nodeStore, k -> new
LinkedHashMap<>()).put(DataStore.class.getName() + ":folder", dataStoreFolder);
}
Review Comment:
> I think it does work: the first call
`components.computeIfAbsent(nodeStore, k -> new LinkedHashMap<>())` will add a
LinkedHashMap (because it is absent) and the second call will re-use it...
Yes, that was the intention, but since it was confusing so I have updated
the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
