thomasmueller commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2468830571
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -700,6 +700,8 @@ private ObjectBuilder<BoolQuery>
inferenceConfigQuery(BoolQuery.Builder b, Strin
KnnQuery.Builder knnQueryBuilder = new
KnnQuery.Builder();
knnQueryBuilder.field(InferenceConstants.VECTOR_SPACES
+ "." + inferenceModelConfigName + "." + InferenceConstants.VECTOR);
knnQueryBuilder.numCandidates(inferenceModelConfig.getNumCandidates());
+ // see
https://github.com/elastic/elasticsearch/pull/118774
+
knnQueryBuilder.k(inferenceModelConfig.getNumCandidates());
Review Comment:
Please add a description in the issue
https://issues.apache.org/jira/browse/OAK-11998 and here.
Even reading the linked page, I don't understand why the change is needed...
Is it for backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
