mbaedke commented on code in PR #2622:
URL: https://github.com/apache/jackrabbit-oak/pull/2622#discussion_r2556715358


##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/internal/concurrent/ExecutorUtils.java:
##########
@@ -36,4 +43,27 @@ public static Executor directExecutor() {
     public static ExecutorService newDirectExecutorService() {
         return new DirectExecutorService();
     }
+
+    public static ExecutorService getExitingExecutorService(ThreadPoolExecutor 
executor) {
+        setDeamonThreadFactory(executor);

Review Comment:
   It's a shutdown hook, so the threads are running only during shutdown. Since 
I have no idea how the deamon flag works in this situation, I was just 
wondering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to