thomasmueller commented on code in PR #2684:
URL: https://github.com/apache/jackrabbit-oak/pull/2684#discussion_r2697353801
##########
oak-core/src/test/java/org/apache/jackrabbit/oak/query/SQL2ParserTest.java:
##########
@@ -87,6 +94,60 @@ public void testUnwrappedOr() throws ParseException {
assertTrue(q.contains(token));
}
+ /*
+ * When a query with LIMIT option, it should still select the index with
the least entries
+ * as those might require being traversed during post-filtering.
+ *
+ * See OAK-12057
+ */
+ @Test
+ public void testPlanningWithLimit() throws ParseException {
+ // Given
+ var query = "SELECT * \n" +
+ "FROM [nt:base] AS s \n" +
+ "WHERE ISDESCENDANTNODE(s, '/content') AND
s.[j:c]='/conf/wknd'\n" +
+ "OPTION (LIMIT 2)";
+
+ // - the first available option
+ var indexA = mock(QueryIndex.AdvancedQueryIndex.class);
+ var planA = mock(QueryIndex.IndexPlan.class);
+ given(indexA.getPlans(any(), any(), any())).willReturn(List.of(planA));
+ given(planA.getPlanName()).willReturn("planA");
+ given(planA.getEstimatedEntryCount()).willReturn(10000L); // more
entries
+ given(planA.getCostPerEntry()).willReturn(1.0);
+ given(planA.getCostPerExecution()).willReturn(100.0);
+
+ // - the better option
+ var indexB = mock(QueryIndex.AdvancedQueryIndex.class);
+ var planB = mock(QueryIndex.IndexPlan.class);
+ given(indexB.getPlans(any(), any(), any())).willReturn(List.of(planB));
+ given(planB.getPlanName()).willReturn("planB");
+ given(planB.getEstimatedEntryCount()).willReturn(100L); // less
entries
+ given(planB.getCostPerEntry()).willReturn(1.0);
+ given(planB.getCostPerExecution()).willReturn(100.0);
+ given(indexB.getPlanDescription(eq(planB), any())).willReturn("planB");
+
+ var indexProvider = new QueryIndexProvider() {
+ @Override
+ public @NotNull List<? extends QueryIndex>
getQueryIndexes(NodeState nodeState) {
+ return List.of(indexA, indexB);
+ }
+ };
+
+ var context = mock(ExecutionContext.class);
+ given(context.getIndexProvider()).willReturn(indexProvider);
+
+ // When
+ var parsedQuery = p.parse(query,false);
+ parsedQuery.init();
+ parsedQuery.setExecutionContext(context);
+ parsedQuery.setTraversalEnabled(false);
+ parsedQuery.prepare();
+
+ // Then
Review Comment:
```suggestion
```
##########
oak-core/src/test/java/org/apache/jackrabbit/oak/query/SQL2ParserTest.java:
##########
@@ -87,6 +94,60 @@ public void testUnwrappedOr() throws ParseException {
assertTrue(q.contains(token));
}
+ /*
+ * When a query with LIMIT option, it should still select the index with
the least entries
+ * as those might require being traversed during post-filtering.
+ *
+ * See OAK-12057
+ */
+ @Test
+ public void testPlanningWithLimit() throws ParseException {
+ // Given
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
