reschke commented on code in PR #2903:
URL: https://github.com/apache/jackrabbit-oak/pull/2903#discussion_r3260906446
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentId.java:
##########
@@ -86,12 +88,17 @@ public static boolean isDataSegmentId(long lsb) {
/**
* Create a new segment id with access tracking.
- * @param store store this is belongs to
- * @param msb most significant bits of this id
- * @param lsb least significant bits of this id
- * @param onAccess callback called whenever an underlying and locally
memoised segment is accessed.
+ *
+ * @param store store this id belongs to
+ * @param msb most significant bits of this id
+ * @param lsb least significant bits of this id
+ * @param onAccess callback invoked whenever the locally memoised segment
is accessed
+ * ({@link #getSegment()}); receives {@code this} (e.g. to
notify {@link SegmentCache}).
+ * <p><strong>API note (Oak 2.1, OAK-12214):</strong> this
parameter type changed from
Review Comment:
Oak 2.1? Should be 2.2.0, right?
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCache.java:
##########
@@ -103,11 +105,25 @@ public abstract Segment getSegment(@NotNull SegmentId id,
@NotNull Callable<Segm
public abstract AbstractCacheStats getCacheStats();
/**
- * Record a hit in this cache's underlying statistics.
+ * Notifies L2 that {@code id} was accessed via L1 memoisation ({@link
SegmentId#getSegment()}).
+ * Updates the backing cache's recency/frequency when the segment is still
cached, and records
+ * a hit in {@link #getCacheStats()}.
*
- * See {@code SegmentId#onAccess}
+ * @param id the segment id that was served from L1
*/
- public abstract void recordHit();
+ public abstract void recordHit(@NotNull SegmentId id);
+
+ /**
+ * Feature toggle name to enable embedded verification for full GC mode
for Mongo Document Store
Review Comment:
????
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
