Amoratinos commented on code in PR #2936:
URL: https://github.com/apache/jackrabbit-oak/pull/2936#discussion_r3381368313
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java:
##########
@@ -528,4 +531,13 @@ public void setSyncManager(@NotNull SyncManager
syncManager) {
public void setIdpManager(@NotNull ExternalIdentityProviderManager
idpManager) {
this.idpManager = idpManager;
}
+
+ public void setMonitor(@NotNull ExternalIdentityMonitor monitor) {
+ this.monitor = monitor;
+ }
Review Comment:
Does it make sense to have a public setter but a getter with default
visibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
