jsedding commented on code in PR #2952:
URL: https://github.com/apache/jackrabbit-oak/pull/2952#discussion_r3401768258
##########
oak-doc/src/site/markdown/osgi_config.md:
##########
@@ -500,6 +500,28 @@ in both config file and framework properties then
framework property takes prece
For example by default Sling sets **repository.home** to
_${sling.home}/repository_. So this value
need not be specified in config files
+#### Feature Toggles
+
+The **Feature Toggle** mechanism enables the safe rollout, testing, and
management of internal repository features.
+It allows new functionality, experimental logic, or performance optimizations
to be shielded behind conditional
+switches that can be controlled at runtime without requiring a repository
restart.
+
+##### Core Architecture
+
+Built upon the **Whiteboard** (the internal service registry), the system
relies on the `FeatureToggle` interface
+from the `org.apache.jackrabbit.oak.spi.toggle` package.
Review Comment:
Technically, the `FeatureToggle` API is not related to the `Whiteboard` at
all.
There _seems_ to be a pattern of registering FT instances with the
whiteboard. However, at the moment, the purpose of this registration eludes me.
Presumably, it is possible to get all FTs, then filter them based on their
`#getName()` to retrieve the desired one, and then use it to "toggle" the FT
via `#setEnabled(boolean)`. Is that what we do? Seemingly not in Oak code,
however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
