thomasmueller commented on code in PR #2959:
URL: https://github.com/apache/jackrabbit-oak/pull/2959#discussion_r3428048201
##########
oak-blob-cloud-azure/pom.xml:
##########
@@ -285,7 +285,6 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
- <version>33.1.0-jre</version>
Review Comment:
It looks like embedded deps don't cause OSGi conflicts at runtime, yes, but
dependencyConvergence runs at Maven dependency resolution time. Maven still
needs to pick a single version for compilation and test.
It looks like we still need to pin the version, because the tests don't use
OSGi. Oak-run also doesn't use OSGi, and some of the jobs we need (eg. for
indexing) do not use OSGi, so I think it's important that we test this as well.
If tests with OSGi (using a different version) are needed, then we could do
that e.g. in oak-it-osgi.
And for OSGi, not every bundle embeds Guava; some import it via
Import-Package.
Pinning is also a way to document things; otherwise Maven would chose
silently (and somewhat arbitrarily) some version and we don't know which one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
