rishabhdaim opened a new pull request, #3033: URL: https://github.com/apache/jackrabbit-oak/pull/3033
## Summary Removes the `FT_NOCOCLEANUP_OAK-10660` feature toggle from `oak-store-document`, following the same pattern used in #2946 (removal of `FT_FULL_GC_OAK-10199`). The toggle was a kill-switch that, when enabled, disabled cleanup of stale `:childOrder` branch-commit entries in `Commit#applyToDocumentStore`. Since the toggle defaults to disabled (i.e. cleanup is enabled by default today), removing it and making the cleanup unconditional preserves today's default behavior exactly — cleanup is now always on, with no way to turn it off. ## Changes - `DocumentNodeStore` — removed `noChildOrderCleanupFeature` field and `isChildOrderCleanupEnabled()` method - `Commit` — made the `:childOrder` branch-commit cleanup unconditional - `DocumentNodeStoreBuilder` / `DocumentNodeStoreService` — removed the field, getter/setter, and toggle registration - Test fixtures (`DocumentMemoryFixture`, `DocumentRdbFixture`, `DocumentMongoFixture`) — removed toggle wiring - `OrderableNodesTest` — removed the toggle-flipping test (no toggle left to flip) - `AGENTS.md` / `oak-store-document/AGENTS.md` — updated docs noting cleanup is now always on with no replacement config ## Test Plan - [x] Added `CommitTest#childOrderCleanupAlwaysEnabled` — creates two branch commits that each set `:childOrder`, merges, then inspects the raw `NodeDocument` to confirm only the latest revision's entry remains. Verified this test fails when the cleanup logic is disabled, confirming it is a genuine regression detector. - [x] `CommitTest`, `DocumentNodeStoreBuilderTest`, `DocumentNodeStoreServiceTest`, `DocumentNodeStoreBranchTest`, `DocumentNodeStoreBranchesTest`, `OrderableNodesTest` (oak-jcr) pass - [x] Full `oak-store-document` test suite passes ## Links - JIRA: https://issues.apache.org/jira/browse/OAK-12316 Co-Authored-By: Claude Sonnet 5 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
