jsedding commented on code in PR #3054:
URL: https://github.com/apache/jackrabbit-oak/pull/3054#discussion_r3689628940
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/AndImpl.java:
##########
@@ -99,7 +99,7 @@ ConstraintImpl not() {
@Override
public Set<PropertyExistenceImpl> getPropertyExistenceConditions() {
- Set<PropertyExistenceImpl> result = new HashSet<>();
+ Set<PropertyExistenceImpl> result = new LinkedHashSet<>();
Review Comment:
TL;DR - if you prefer, I can remove this change.
This change is only present to make
`org.apache.jackrabbit.oak.query.ast.PropertyExistenceTest#andXY` fully
deterministic.
With the other changes present, the test seems to pass reliably even without
this change. Presumably this is due to the `#hashCode()` implementations.
However during development, before I settled on the current
`PropertyExistenceImpl#hashCode()` implementation, the test failed for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
