The GitHub Actions job "Build" on jackrabbit-oak.git/issue/OAK-12331-impl has failed. Run started by GitHub user dulvac (triggered by dulvac).
Head commit for run: f1fccf94cc763e91ed6c4c44fd1864854e33818d / Andrei Dulvac <[email protected]> OAK-12331: address the second round of review on the audit SPI >From the review on PR #3059: - Move AuditEventImpl into spi.audit.impl, which is not exported. The class was already package-private, so it never reached the API surface, but BND computes the baseline version per package: editing it could have bumped the exported package's version with no API change. It has to be public now, since AuditEvent.of in the parent package constructs it. - Rename AuditEvents to AuditDispatch. Oak's plural-facade convention (PropertyValues, NodeStates) means "factory for the singular type", and this class never builds an AuditEvent — AuditEvent.of does. It installs a sink and routes, so name it for that. - Return an empty list from AuditBuffer.peek and drain instead of null. The one production caller had a redundant null check; the tests now assert emptiness rather than null. - Drop the explicit ArrayList capacity in SessionBuffer and use the default. - Say "unmodifiable shallow copy" on peek rather than "defensive copy". The reviewer read it as a deep copy; List.copyOf is not one, and the shared AuditEvent instances are safe because events are immutable. The AuditDomain / AuditType value types the same review asked for landed earlier in c955987672. Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/31675138933 With regards, GitHub Actions via GitBox
