mbaedke commented on code in PR #3080:
URL: https://github.com/apache/jackrabbit-oak/pull/3080#discussion_r3776826370
##########
oak-auth-ldap/src/test/java/org/apache/jackrabbit/oak/security/authentication/ldap/AbstractServer.java:
##########
@@ -230,7 +233,12 @@ private void startLdapServer() throws Exception {
protected void setupLdapServer() throws Exception {
TcpTransport transport = new TcpTransport((port));
transport.enableSSL(enableSSL);
-
+ URL keyStoreUrl =
AbstractServer.class.getClassLoader().getResource(TLS_KEYSTORE_RESOURCE);
+ if (keyStoreUrl == null) {
+ throw new IOException("Unable to locate test TLS keystore: " +
TLS_KEYSTORE_RESOURCE);
+ }
+ ldapServer.setKeystoreFile(new
File(keyStoreUrl.toURI()).getAbsolutePath());
+ ldapServer.setCertificatePassword(TLS_KEYSTORE_PASSWORD);
Review Comment:
I don't understand. These are completely different configuration settings
(AFAIR one for LDAPS and the other for LDAP over TLS) and we shouldn't change
the semantics of the test with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
