bhabegger commented on code in PR #3084:
URL: https://github.com/apache/jackrabbit-oak/pull/3084#discussion_r3796722368
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/xpath/XPathToSQL2Converter.java:
##########
@@ -1006,6 +1007,9 @@ private void initialize(String query) throws
ParseException {
} else {
if (Character.isJavaIdentifierPart(c)) {
type = CHAR_NAME;
+ } else if ((settings == null ||
settings.isXmlNameCharsInPathEnabled()) && XMLChar.isName(c)) {
Review Comment:
Shouldn't we not enable this if settings is null (to keep the existing
behavior in that case) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
