bhabegger commented on PR #3086: URL: https://github.com/apache/jackrabbit-oak/pull/3086#issuecomment-5338346764
[AI] Addressed feedback from an internal automated review: - Registered `FT_OAK-12365` as a `FeatureToggle` on the Whiteboard in both `LuceneIndexProviderService` and `ElasticIndexProviderService` — it was declared but never wired, so the kill switch had no effect at runtime. - Added a unit test verifying `FT_OAK_12365_DISABLE` actually suppresses the deletion. - Added a unit test verifying that removing one of several aggregated properties does *not* delete the document (only fully-empty content should). - Reset `FT_OAK_12365_DISABLE` in `@Before`/`@After` alongside the existing `FT_OAK_12244_DISABLE` reset. - Added a debug log line on the new deletion path, matching the existing trace log on the update path. Full `oak-search` + `oak-lucene` (1252 tests) and `oak-search-elastic` (512 tests) suites pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
