mkapalka commented on code in PR #3154:
URL: https://github.com/apache/jackrabbit-oak/pull/3154#discussion_r4095465852


##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandlerTest.java:
##########
@@ -179,4 +191,57 @@ public void multipleIndexes() throws IOException {
         Assert.assertFalse(bulkProcessorHandler.flushIndex("index2"));
         bulkProcessorHandler.close();
     }
+
+    @Test
+    public void partialUpdateSetsRetryOnConflictByDefault() throws IOException 
{
+        ElasticBulkProcessorHandler handler = new 
ElasticBulkProcessorHandler(elasticConnectionMock);
+        try {
+            BulkOperation op = handler.buildUpdateOperation("index", "id", new 
ElasticDocument("/content/foo"));
+            
Assert.assertEquals(Integer.valueOf(ElasticBulkProcessorHandler.RETRY_ON_CONFLICT_DEFAULT),

Review Comment:
   Minor detail: use static imports for test static methods like this one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to