ChlineSaurus commented on code in PR #3248:
URL: https://github.com/apache/jackrabbit-oak/pull/3248#discussion_r4440160583
##########
oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexMergerTest.java:
##########
@@ -21,8 +21,10 @@
import java.io.IOException;
import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
Review Comment:
I think those two imports here are not required. (List and Array List)
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexMerger.java:
##########
@@ -493,7 +493,7 @@ public static JsonObject mergeDiffs(JsonObject a,
JsonObject b) {
}
JsonObject result = JsonObject.fromJson(a.toString(), true);
result.getProperties().putAll(b.getProperties());
- HashSet<String> both = new HashSet<>(a.getChildren().keySet());
+ LinkedHashSet<String> both = new
LinkedHashSet<>(a.getChildren().keySet());
Review Comment:
> There is no need for a feature toggle, because in this case, in case of
trouble, we can roll back to the Oak version.
Yes, but this would roll back all Oak changes. But I think it's fine with
such a small, targeted fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
