thomasmueller commented on code in PR #3260:
URL: https://github.com/apache/jackrabbit-oak/pull/3260#discussion_r4452781597
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java:
##########
@@ -559,7 +561,13 @@ private void runWhenPermitted() {
log.debug(
"[{}] No changes since last checkpoint; skipping the
index update",
name);
- postAsyncRunStatsStatus(indexStats);
+ try {
+ persistLastSuccessfulCycle(beforeCheckpoint,
async.getLong(leasify(name)));
+ postAsyncRunStatsStatus(indexStats);
+ } catch (CommitFailedException e) {
+ log.warn("[{}] Unable to persist successful cycle
timestamp", name, e);
+ indexStats.failed(e);
+ }
Review Comment:
```suggestion
try {
persistLastSuccessfulCycle(beforeCheckpoint,
async.getLong(leasify(name)));
} catch (CommitFailedException e) {
log.warn("[{}] Unable to persist successful cycle
timestamp", name, e);
indexStats.failed(e);
}
postAsyncRunStatsStatus(indexStats);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]