anchela opened a new pull request, #3286:
URL: https://github.com/apache/jackrabbit-oak/pull/3286

   [OAK-12495](https://issues.apache.org/jira/browse/OAK-12495): Monitor admin 
user operations
   
   Adds meters to the existing `UserMonitor` / `UserMonitorImpl` for security 
relevant operations on the admin user:
   
   | Meter | Recorded in |
   |---|---|
   | `security.user.admin.login.succeeded` / `.failed` | `UserAuthentication` 
(password login; expired password not changed during login counts as failed) |
   | `security.user.admin.impersonation.succeeded` / `.failed` | 
`UserAuthentication` (admin as impersonation target, incl. self-impersonation) |
   | `security.user.admin.password.added` / `.changed` | `UserValidator` (added 
= admin had no password before, e.g. `omitAdminPw`) |
   | `security.user.admin.impersonators.granted` / `.revoked` | `UserValidator` 
(set diff of `rep:impersonators`) |
   
   - Content-change metrics are detected during commit validation, covering 
every write path (user management API, XML import, plain Oak API). They are 
best-effort: a later validation/merge failure may still leave them incremented 
and retries may overcount; they are not an audit trail.
   - No user ids or principal names in metrics. Purely additive with NOOP 
defaults, no feature toggle. `security.user.monitor` is not exported (no 
baseline impact).
   - Docs: new "Monitoring" section in `oak-doc/.../security/user/default.md` 
listing all `security.user.*` metrics.
   - Spec and plan: `specs/OAK-12495/SPEC.md`, `specs/OAK-12495/PLAN.md` (incl. 
out-of-scope items and decisions).
   
   Tests: `AdminUserMonitorTest`, `AdminUserMonitorOmitPasswordTest`, 
`UserImporterAdminMonitorTest`, `UserMonitorImplTest`; oak-core coverage gates 
pass, full build green locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to