cdamioli commented on PR #3263:
URL: https://github.com/apache/jackrabbit-oak/pull/3263#issuecomment-6820266349

   The code coverage is not good here, because of the big class enumerating 
many Unicode characters with diactricical parts.
   I could easily improve that code coverage by providing a unit test with each 
and every Unicode char, but I don't know if it's really useful.
   
   By the way, when implementing the feature, I had the choice between two 
paths:
    - copying the Lucene's ASCIIFoldingFilter, mirroring the Jackrabbit 
implementation. Pros: faster. Cons: a full class to copy.
    - using the JDK native java.text.Normalizer. Pros: smaller code. Cons: 
heavier, and less cases covered.
   
   I took the Lucene path, feel free to disagree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to