ChlineSaurus commented on code in PR #3294:
URL: https://github.com/apache/jackrabbit-oak/pull/3294#discussion_r4564376009


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexMerger.java:
##########
@@ -152,8 +152,8 @@ public void merge(JsonObject newImageLuceneDefinitions, 
JsonObject repositoryDef
         // because they are not regular index definitions,
         // and so they are not in the repositoryDefinitions
         if (repositoryNodeStore != null) {
-            Map<String, JsonObject> diffInRepo = 
readDiffIndex(repositoryNodeStore, DIFF_INDEX_OPTIMIZER);
-            combined.getChildren().putAll(diffInRepo);
+            combined.getChildren().putAll(readDiffIndex(repositoryNodeStore, 
DIFF_INDEX));

Review Comment:
   Rest looks good, but on this change I don't have enough context. Is this 
just a follow up from allowing multiple SIM definitions? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to