[ 
https://issues.apache.org/jira/browse/OAK-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490578#comment-13490578
 ] 

Thomas Mueller commented on OAK-388:
------------------------------------

> I wonder if we should rather just replace Filter with a Constraint from the 
> abstract query tree.

That's possible, but the risk is that it would make index implementations a lot 
more complex, as all of them would have to understand all possible constraints. 
The idea of the Filter class is to help make index implementations as simple as 
possible. But the Filter currently is too simple, I understand that.

> require extending the Filter mechanism with support for OR clauses.

Yes, some of this would be nice, for example for conditions of the form "x = 1 
or x = 2 or x = 3" - which is the same as "x in (1, 2, 3)". But I think (hope) 
this can be solved within the Filter by supporting lists instead of just value 
ranges as of now. Possibly this would work for node types as well.

By the way, for conditions of the form "x = 1 or y = 2", I guess it would make 
more sense to convert that to a union internally (select ... where x = 1 union 
select ... where y = 2). That way, it is possible to use multiple indexes (the 
index for x and the index for y) without the indexes having to know about each 
other.
                
> Add NodeType Index
> ------------------
>
>                 Key: OAK-388
>                 URL: https://issues.apache.org/jira/browse/OAK-388
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Alex Parvulescu
>            Assignee: Marcel Reutegger
>             Fix For: 0.6
>
>         Attachments: oak-core-property-index.patch
>
>
> I'm proposing a new property index for node types.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to