[
https://issues.apache.org/jira/browse/OAK-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490691#comment-13490691
]
Thomas Mueller commented on OAK-388:
------------------------------------
The patch looks good to me as an initial implementation.
In the same way as the PropertyIndexLookup, it loads all paths in memory.
In the query method, instead of creating a TraversingCursor, would it make
sense to throw an exception? This would also apply to PropertyIndex. For me,
'switching' to a traversing sounds like a bug in the cost calculation or the
query engine. As an alternative, the query method could return null, so that
the query engine would notice and switch to the TraversingIndex itself.
But those are details we can discuss and change later on as well.
+1 to commit the patch.
> Add NodeType Index
> ------------------
>
> Key: OAK-388
> URL: https://issues.apache.org/jira/browse/OAK-388
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: Alex Parvulescu
> Assignee: Marcel Reutegger
> Fix For: 0.6
>
> Attachments: OAK-388.patch, oak-core-property-index.patch
>
>
> I'm proposing a new property index for node types.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
