[ 
https://issues.apache.org/jira/browse/OAK-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890811#comment-13890811
 ] 

Michael Dürig commented on OAK-1386:
------------------------------------

The patch doesn't cleanly apply for me. However generally +1 for such an 
approach. 

> Move tree type to permission implementation
> -------------------------------------------
>
>                 Key: OAK-1386
>                 URL: https://issues.apache.org/jira/browse/OAK-1386
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>         Attachments: OAK-1386.patch
>
>
> As suggested by jukka on the mailing list we may consider removing the tree 
> type from the ImmutableTree and ImmutableRoot and just keep it inside the 
> permission evaluation code.
> pro: simplify ImmutableTree
> con: for PermissionProvider#isGranted and PermissionProvider#hasPrivilege the 
> treepermission object is not present and retrieving the type *always* will 
> walk up the hierarchy to retrieve the type of the parent with the associated 
> performance impact. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to