[
https://issues.apache.org/jira/browse/OAK-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890830#comment-13890830
]
Jukka Zitting commented on OAK-1386:
------------------------------------
bq. con: for PermissionProvider#isGranted and PermissionProvider#hasPrivilege
the treepermission object is not present and retrieving the type always will
walk up the hierarchy to retrieve the type of the parent with the associated
performance impact.
The {{isGranted()}} and {{hasPrivilege()}} method are hardly ever
performance-critical, as their main purpose is to provide guidance to a human
user interface about which operations are available. So I wouldn't worry too
much about extra performance overhead here.
> Move tree type to permission implementation
> -------------------------------------------
>
> Key: OAK-1386
> URL: https://issues.apache.org/jira/browse/OAK-1386
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
> Assignee: angela
> Attachments: OAK-1386.patch
>
>
> As suggested by jukka on the mailing list we may consider removing the tree
> type from the ImmutableTree and ImmutableRoot and just keep it inside the
> permission evaluation code.
> pro: simplify ImmutableTree
> con: for PermissionProvider#isGranted and PermissionProvider#hasPrivilege the
> treepermission object is not present and retrieving the type *always* will
> walk up the hierarchy to retrieve the type of the parent with the associated
> performance impact.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
