[
https://issues.apache.org/jira/browse/OAK-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890819#comment-13890819
]
angela commented on OAK-1386:
-----------------------------
i am just a bit hesitating because of the drawback. while i usually claim that
applications should *not* check for permissions manually, i can't prevent them
from doing so and i would obviously not want to introduce any extra performance
problems.
> Move tree type to permission implementation
> -------------------------------------------
>
> Key: OAK-1386
> URL: https://issues.apache.org/jira/browse/OAK-1386
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
> Assignee: angela
> Attachments: OAK-1386.patch
>
>
> As suggested by jukka on the mailing list we may consider removing the tree
> type from the ImmutableTree and ImmutableRoot and just keep it inside the
> permission evaluation code.
> pro: simplify ImmutableTree
> con: for PermissionProvider#isGranted and PermissionProvider#hasPrivilege the
> treepermission object is not present and retrieving the type *always* will
> walk up the hierarchy to retrieve the type of the parent with the associated
> performance impact.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
