[
https://issues.apache.org/jira/browse/OAK-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661753#comment-14661753
]
Davide Giannella commented on OAK-2977:
---------------------------------------
[~tmueller]
Overall the patch sounds good to me. What I (personally) don't like, but it's
more a wish rather than something wrong:
{noformat: title=PrefetchIterator.java}
LOG.info("prefetch It " + minPrefetch + " max:" + maxPrefetch + " fast:" +
fastSizeCallback + " size:" + size );
{noformat}
maybe better at debug level. Sounds very much a debug information to me.
Class {{PrefetchOptions}} I'd rather have it immutable or behind getter/setter.
With "immutable" I mean all finals and set via constructors.
bq. Changing the RepositoryImpl constructor did not require a version change
I think that's because RepositoryImpl is an implementation detail class (not
exposed) while the Jcr class is exposed and adding a method means changing of
the API.
> Fast result size estimate: OSGi configuration
> ---------------------------------------------
>
> Key: OAK-2977
> URL: https://issues.apache.org/jira/browse/OAK-2977
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Labels: doc-impacting
> Fix For: 1.3.5
>
> Attachments: OAK-2977.patch
>
>
> The fast result size option in OAK-2926 should be configurable, for example
> over OSGi.
> The resultFetchSize should be configurable as well. Currently it is hardcoded
> (PREFETCH_MAX = 100).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
