[
https://issues.apache.org/jira/browse/OAK-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661781#comment-14661781
]
Thomas Mueller commented on OAK-2977:
-------------------------------------
> LOG.info("prefetch It"
Yes sorry, I forgot about that, it was for debugging.
> Class PrefetchOptions
It doesn't need to be immutable because the values are copied, so it's secure.
I wanted to avoid using getters and setters, because that would just add more
code without real help. I understand if this was public API I would use a
Builder with getters and setters, but here I think the [simple named-parameter
pattern|http://stackoverflow.com/questions/1988016/named-parameter-idiom-in-java]
is a good match for this case. Similar to the "anonymous class HashSet/HashMap
constructor" we use elsewhere in Oak. I really wanted to get rid of the many
parameters in the constructor, but didn't want a huge amount of code for that,
as it is really just used twice, and not public.
> I think that's because RepositoryImpl is an implementation detail class (not
> exposed)
Well, it is exposed: it is a public class, and it can be extended, as in "class
Acme3RepositoryImpl extends RepositoryImpl". I would prefer if it is not
necessary to directly use this class... I think it breaks modularity.
> Fast result size estimate: OSGi configuration
> ---------------------------------------------
>
> Key: OAK-2977
> URL: https://issues.apache.org/jira/browse/OAK-2977
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Labels: doc-impacting
> Fix For: 1.3.5
>
> Attachments: OAK-2977-b.patch, OAK-2977.patch
>
>
> The fast result size option in OAK-2926 should be configurable, for example
> over OSGi.
> The resultFetchSize should be configurable as well. Currently it is hardcoded
> (PREFETCH_MAX = 100).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
