[ 
https://issues.apache.org/jira/browse/OAK-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661846#comment-14661846
 ] 

Davide Giannella commented on OAK-2977:
---------------------------------------

While on chat with [~tmueller] we noticed that the change 

{code:title=OsgiRepository.java}
Index: src/main/java/org/apache/jackrabbit/oak/jcr/osgi/OsgiRepository.java
===================================================================
--- src/main/java/org/apache/jackrabbit/oak/jcr/osgi/OsgiRepository.java        
(revision 1694664)
+++ src/main/java/org/apache/jackrabbit/oak/jcr/osgi/OsgiRepository.java        
(working copy)
@@ -38,8 +38,10 @@
                           Whiteboard whiteboard,
                           SecurityProvider securityProvider,
                           int observationQueueLength,
-                          CommitRateLimiter commitRateLimiter) {
-        super(repository, whiteboard, securityProvider, 
observationQueueLength, commitRateLimiter);
+                          CommitRateLimiter commitRateLimiter,
+                          boolean fastQueryResultSize) {
+        super(repository, whiteboard, securityProvider, 
observationQueueLength, 
+                commitRateLimiter, fastQueryResultSize);
     }
{code}

could brake retro-compatibilty with repositories already in place using the old 
behaviour. We agreed on overload with another constructor that won't make use 
the {{fastQueryResultSize}} which will force the old behaviour.

> Fast result size estimate: OSGi configuration
> ---------------------------------------------
>
>                 Key: OAK-2977
>                 URL: https://issues.apache.org/jira/browse/OAK-2977
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>              Labels: doc-impacting
>             Fix For: 1.3.5
>
>         Attachments: OAK-2977-b.patch, OAK-2977.patch
>
>
> The fast result size option in OAK-2926 should be configurable, for example 
> over OSGi.
> The resultFetchSize should be configurable as well. Currently it is hardcoded 
> (PREFETCH_MAX = 100).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to