[
https://issues.apache.org/jira/browse/OAK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385545#comment-15385545
]
Alex Parvulescu commented on OAK-4451:
--------------------------------------
a minor observation (probably IDE introduced), you used the following java 7
constructs in the {{ReaderCache}}: {{new CacheKey<>(hash, msb, lsb, offset)}}
and {{new FastCacheEntry<>(hash, msb, lsb, offset, value))}}, I think it would
be simpler to write the types (I'm mainly thinking backports), but that might
be just me. if this was on purpose, then please ignore the comment.
> Implement a proper template cache
> ---------------------------------
>
> Key: OAK-4451
> URL: https://issues.apache.org/jira/browse/OAK-4451
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: cache, monitoring, production
> Fix For: 1.6, Segment Tar 0.0.6
>
>
> The template cache is currently just a map per segment. This is problematic
> in various ways:
> * A segment needs to be in memory and probably loaded first only to read
> something from the cache.
> * No monitoring, instrumentation of the cache
> * No control over memory consumption
> We should there for come up with a proper template cache implementation in
> the same way we have done for strings ({{StringCache}}) in OAK-3007.
> Analogously that cache should be owned by the {{CachingSegmentReader}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
