[
https://issues.apache.org/jira/browse/OAK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385575#comment-15385575
]
Michael Dürig commented on OAK-4451:
------------------------------------
Good point! I don't think there really is a problem here as we specify the
weight of the cache entries explicitly by using the respective {{put}} method.
However, the semantics and interactions of the various weight related methods,
parameters and method arguments is very confusing. I think we need to clarify
this first and then clean up the implementations. I'll file a separate issue
for that and follow up with [~tmueller].
> Implement a proper template cache
> ---------------------------------
>
> Key: OAK-4451
> URL: https://issues.apache.org/jira/browse/OAK-4451
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: cache, monitoring, production
> Fix For: 1.6, Segment Tar 0.0.6
>
>
> The template cache is currently just a map per segment. This is problematic
> in various ways:
> * A segment needs to be in memory and probably loaded first only to read
> something from the cache.
> * No monitoring, instrumentation of the cache
> * No control over memory consumption
> We should there for come up with a proper template cache implementation in
> the same way we have done for strings ({{StringCache}}) in OAK-3007.
> Analogously that cache should be owned by the {{CachingSegmentReader}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
