[
https://issues.apache.org/jira/browse/OAK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385556#comment-15385556
]
Alex Parvulescu commented on OAK-4451:
--------------------------------------
Another {{ReaderCache}} question related to the use of a {{weigher}} for the
CacheStats only. I think the stats object would not be reflecting the cache's
real behavior as the cache itself would use the default {{.averageWeight(250)}}
to evaluate the cache's footprint, so you'd have access to an accurate cache
footprint, but there would be no indication on why the cache doesn't maintain
the provided max size, which would confuse people.
Also, I'm pretty sure you also have to include the cache key in the weight
calculation not just the value.
> Implement a proper template cache
> ---------------------------------
>
> Key: OAK-4451
> URL: https://issues.apache.org/jira/browse/OAK-4451
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: cache, monitoring, production
> Fix For: 1.6, Segment Tar 0.0.6
>
>
> The template cache is currently just a map per segment. This is problematic
> in various ways:
> * A segment needs to be in memory and probably loaded first only to read
> something from the cache.
> * No monitoring, instrumentation of the cache
> * No control over memory consumption
> We should there for come up with a proper template cache implementation in
> the same way we have done for strings ({{StringCache}}) in OAK-3007.
> Analogously that cache should be owned by the {{CachingSegmentReader}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
