[ 
https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395791#comment-15395791
 ] 

Thomas Mueller commented on OAK-4522:
-------------------------------------

In general I will try to find a simple solution, but test it well. I'm not sure 
if OAK-4122 is simple, specially if this issue should be addressed as well. 

I will check if adding the delay loop in MutableRoot.commit is better than 
using a CommitHook (so the delay happens outside the lock).

Also, I think that using a delay time (milliseconds) is not needed. Instead, 
just delay until the queue is smaller. I think that's simpler (no formula is 
needed) and will basically have the same effect.

> Improve CommitRateLimiter to optionally block some commits
> ----------------------------------------------------------
>
>                 Key: OAK-4522
>                 URL: https://issues.apache.org/jira/browse/OAK-4522
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>
> The CommitRateLimiter of OAK-1659 can delay commits, but doesn't currently 
> block them, and delays even those commits that are part of handling events. 
> Because of that, the queue can still get full, and possibly delaying commits 
> while handling events can make the situation even worse.
> In Jackrabbit 2.x, we had a similar feature: JCR-2402. Also related is 
> JCR-2746.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to