[ 
https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397550#comment-15397550
 ] 

Thomas Mueller commented on OAK-4522:
-------------------------------------

The CommitRateLimiter currently only gets informed about added entries (when 
the queue grows), but not about removed entries (when the queue shrinks). That 
means once the commit rate limiter blocks commits, in the (unusual but 
possible) case that no new entries are added to the queue, it would never 
un-block. Support for removing events on removing entries is available in the 
second patch of OAK-4543.

> Improve CommitRateLimiter to optionally block some commits
> ----------------------------------------------------------
>
>                 Key: OAK-4522
>                 URL: https://issues.apache.org/jira/browse/OAK-4522
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>
> The CommitRateLimiter of OAK-1659 can delay commits, but doesn't currently 
> block them, and delays even those commits that are part of handling events. 
> Because of that, the queue can still get full, and possibly delaying commits 
> while handling events can make the situation even worse.
> In Jackrabbit 2.x, we had a similar feature: JCR-2402. Also related is 
> JCR-2746.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to