[
https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042407#comment-16042407
]
angela edited comment on OAK-6304 at 6/8/17 9:10 AM:
-----------------------------------------------------
[~tmueller], I gave it a try to sort out the cyclic dependencies between
_oak.spi.query_ and _oak.query.*_ and came to a proposal that additionally
allowed us to remove the package export of _o.a.j.oak.query_.
unfortunately, i didn't get started with my git-fork... anyway... the quick
summary of the proposed changes as follows:
- copy {{QueryEngineSettings}} to _o.a.j.oak.spi.query_. Note: I would have
preferred to moved it but this would have caused a major version increase in
_o.a.j.oak.plugins.tree_.
- adjust all references to {{QueryEngineSettings}} except for the one in
_o.a.j.oak.plugins.tree_. There i deprecated the method using
{{QueryEngineSettings}}
- move everything in _org.apache.jackrabbit.oak.query.fulltext_ to
_org.apache.jackrabbit.oak.spi.query.fulltext_
- move {{o.a.j.oak.spi.Cursors}} utility to _o.a.j.oak.query.index_
[~mduerig], [~teofili], [~rombert], i would also like you to look at the
proposed changes.
Also note that I initially focused on _o.a.j.oak.query_ and
_o.a.j.oak.spi.query_, the index related packages I didn't yet have time to
look at.
was (Author: anchela):
[~tmueller], I gave it a try to sort out the cyclic dependencies between
_oak.spi.query_ and _oak.query.*_ and came to a proposal that additionally
allowed us to remove the package export of _o.a.j.oak.query_.
unfortunately, i didn't get started with my git-fork... anyway... the quick
summary of the proposed changes as follows:
- copy {{QueryEngineSettings}} to _o.a.j.oak.spi.query_. Note: I would have
preferred to moved it but this would have caused a major version increase in
_o.a.j.oak.plugins.tree_.
- adjust all references to {{QueryEngineSettings}} except for the one in
_o.a.j.oak.plugins.tree_. There i deprecated the method using
{{QueryEngineSettings}}
- move everything in _org.apache.jackrabbit.oak.query.fulltext_ to
_org.apache.jackrabbit.oak.spi.query.fulltext_
- move {{o.a.j.oak.spi.Cursors}} utility to _o.a.j.oak.query.index_
[~mduerig], [~teofili], [~rombert], i would also like you to look at the
proposed changes.
> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>
> Key: OAK-6304
> URL: https://issues.apache.org/jira/browse/OAK-6304
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core, indexing, query
> Reporter: angela
> Attachments: OAK-6304.patch, OAK-6304-test.patch
>
>
> while working on OAK-6069 i noticed that there exist IMO troublesome
> dependencies from _o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i
> don't know the historical reasons that led to this setup it feels wrong to me
> that the interfaces and classes in _o.a.j.oak.spi.query_ would have
> dependencies to packages that from my understanding are supposed to contain
> implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up
> in the wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i
> couldn't find an easy solution for an interface like
> {{o.a.j.oak.spi.query.Filter}} that defines methods returning
> {{o.a.j.query.fulltext.FullTextExpression}} and
> {{o.a.j.query.QueryEngineSettings}}, while at the same time being tied to the
> {{o.a.j.oak.spi.query.QueryIndex}} interface.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
