[
https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046620#comment-16046620
]
angela edited comment on OAK-6304 at 6/12/17 2:33 PM:
------------------------------------------------------
[~tmueller], while waiting for your feedback, i took a look at dependencies
from _oak.spi.query_ to _oak.plugins.index_ and found that there is just a
single one: {{QueryIndex.FulltextQueryIndex}} defines a method that returns
{{o.a.j.oak.plugins.index.aggregate.NodeAggregator}}. would it make sense to
move the {{NodeAggregator}} to some _spi.query_-space in order to also cleanup
the cyclic dependencies between the _oak.plugins.index_ and the query-spi?
wdyt? (i would cover that with a separate jira ticket if you agree)
was (Author: anchela):
[~tmueller], while waiting for your feedback, i took a look at dependencies
from _oak.spi.query_ to _oak.plugins.index_ and found that there is just a
single one: {{QueryIndex.FulltextQueryIndex}} defines a method that returns
{{o.a.j.oak.plugins.index.aggregate.NodeAggregator}}. would it make sense to
move the {{NodeAggregator}} to some _spi.query_-space in order to also cleanup
the cyclic dependencies between the _oak.plugins.index_ and the query-spi? wdyt?
> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>
> Key: OAK-6304
> URL: https://issues.apache.org/jira/browse/OAK-6304
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core, indexing, query
> Reporter: angela
> Attachments: OAK-6304-2.patch, OAK-6304-2-test.patch, OAK-6304.patch,
> OAK-6304-test.patch
>
>
> while working on OAK-6069 i noticed that there exist IMO troublesome
> dependencies from _o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i
> don't know the historical reasons that led to this setup it feels wrong to me
> that the interfaces and classes in _o.a.j.oak.spi.query_ would have
> dependencies to packages that from my understanding are supposed to contain
> implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up
> in the wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i
> couldn't find an easy solution for an interface like
> {{o.a.j.oak.spi.query.Filter}} that defines methods returning
> {{o.a.j.query.fulltext.FullTextExpression}} and
> {{o.a.j.query.QueryEngineSettings}}, while at the same time being tied to the
> {{o.a.j.oak.spi.query.QueryIndex}} interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
