[
https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042721#comment-16042721
]
angela edited comment on OAK-6304 at 6/8/17 1:54 PM:
-----------------------------------------------------
[~tmueller], alternative patches with the following additional changes to
remove the WARNINGs from the maven plugins:
* move {{Cursors}} again... to _o.a.j.oak.plugins.index_
* introduce {{o.a.j.oak.spi.query.Filter#EMPTY_FILTER}} use this one in
{{CrossMountReferenceValidator}} (instead of constructing an empty
{{FilterImpl}}. NOTE: that needs an extra look though i tried to provide the
same thing that {{new FilterImpl(null, null, new QueryEngineSettings()}}
* drop package export of of
** _o.a.j.oak.ast_
** _o.a.j.oak.index_
** _o.a.j.oak.facets_
So, no further adjustment/move needed for the classes in the _ast_ or the
_index_ package. I ran the complete build with _-PintegrationTesting_ and it
passed. I didn't try to integrate it yet with our code outside of the Oak code
base though.
was (Author: anchela):
[~tmueller], alternative patches with the following additional changes to
remove the WARNINGs from the maven plugins:
* move {{Cursors}} again... to _o.a.j.oak.plugins.index_
* introduce {{o.a.j.oak.spi.query.Filter#EMPTY_FILTER}} use this one in
{{CrossMountReferenceValidator}} (instead of constructing an empty
{{FilterImpl}}. NOTE: that needs an extra look though i tried to provide the
same thing that {{new FilterImpl(null, null, new QueryEngineSettings()}}
* drop package export of of
** _o.a.j.oak.ast_
** _o.a.j.oak.index_
** _o.a.j.oak.facets_
So, no further adjustment/move needed for the classes in the _ast_ or the
_index_ package.
> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>
> Key: OAK-6304
> URL: https://issues.apache.org/jira/browse/OAK-6304
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core, indexing, query
> Reporter: angela
> Attachments: OAK-6304-2.patch, OAK-6304-2-test.patch, OAK-6304.patch,
> OAK-6304-test.patch
>
>
> while working on OAK-6069 i noticed that there exist IMO troublesome
> dependencies from _o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i
> don't know the historical reasons that led to this setup it feels wrong to me
> that the interfaces and classes in _o.a.j.oak.spi.query_ would have
> dependencies to packages that from my understanding are supposed to contain
> implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up
> in the wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i
> couldn't find an easy solution for an interface like
> {{o.a.j.oak.spi.query.Filter}} that defines methods returning
> {{o.a.j.query.fulltext.FullTextExpression}} and
> {{o.a.j.query.QueryEngineSettings}}, while at the same time being tied to the
> {{o.a.j.oak.spi.query.QueryIndex}} interface.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
