[
https://issues.apache.org/jira/browse/OAK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066625#comment-16066625
]
Matt Ryan commented on OAK-6388:
--------------------------------
I'm still not comfortable with the comments in {{AzureConstants.java}}. I
don't think they have the effect of clarifying the code. In particular, the
usage of the word "key" in each comment confuses me, because it doesn't seem to
match the name of each constant.
For example:
{noformat}
/**
* Azure storage account name key
*/
public static final String AZURE_STORAGE_ACCOUNT_NAME = "accessKey";
{noformat}
The value of the string is "accessKey". Originally this was to be consistent
with S3 which uses the config names "accessKey" and "secretKey". In Azure's
case the equivalent is the storage account name. It isn't a key, it is just a
name. If we are going to put a comment here (esp. a JavaDoc comment) I think
we should explain what it is - for example: "The Azure storage account name.
Used as the access key to connect to a storage account."
{noformat}
/**
* Azure shared access signature key
*/
public static final String AZURE_SAS = "azureSas";
{noformat}
It isn't a key, it is the shared access signature. If I were unfamiliar with
the code and with Azure storage, I might see this and wonder "I have a shared
access signature - but how do I get the key for it?"
> Enable Azure shared access signature for blob store connector
> -------------------------------------------------------------
>
> Key: OAK-6388
> URL: https://issues.apache.org/jira/browse/OAK-6388
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob-cloud
> Reporter: Andrei Kalfas
> Attachments: AzureSAS.patch, AzureSAS-v2.patch
>
>
> Azure storage account can be access with access keys or with shared access
> signatures. Currently the blob connector only allows access keys, limiting
> the use cases where the storage account must be regarded as a read only one.
> Access keys enable all access while shared access signatures can be limited
> to certain operations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
