[ 
https://issues.apache.org/jira/browse/OAK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066724#comment-16066724
 ] 

Raul Hudea commented on OAK-6388:
---------------------------------

For the initial review of the AzureDataStore, a decision was made to use the 
same name for properties of similar purpose and their purpose would be 
explained via documentation

>From the initial [review|https://github.com/apache/jackrabbit-oak/pull/58]:
{quote}Same for S3 and Azure:
accessKey - used as accessKey for S3 and as accountName in Azure
secretKey - used as secretKey for S3 and as accountKey in Azure
maxErrorRetry - same for S3 and Azure
socketTimeout - socket timeout for S3 and timeout interval for Azure
proxyHost - same for S3 and Azure
proxyPort - same for S3 and Azure
maxConnections - maximum connections to S3 / in Azure: Concurrent number of 
simultaneous requests per operation

Only in S3
s3Bucket
rest of other s3 only properties that are not used in Azure

Only in Azure
container {quote}


I think the confusion about the case inconsistency is related to the fact that 
I've capitalised  the Azure terminology ("Storage Account" and "Storage Account 
Key") and left the clarifying terms in lower case ("name")
 
Maybe fixing the original typo and removing the "Key" from the "Azure Shared 
Access Signature Key" and "Azure Blob Endpoint Key" is enough (from the first 
patch)

> Enable Azure shared access signature for blob store connector
> -------------------------------------------------------------
>
>                 Key: OAK-6388
>                 URL: https://issues.apache.org/jira/browse/OAK-6388
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob-cloud
>            Reporter: Andrei Kalfas
>         Attachments: AzureSAS.patch, AzureSAS-v2.patch
>
>
> Azure storage account can be access with access keys or with shared access 
> signatures. Currently the blob connector only allows access keys, limiting 
> the use cases where the storage account must be regarded as a read only one. 
> Access keys enable all access while shared access signatures can be limited 
> to certain operations. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to