[
https://issues.apache.org/jira/browse/OAK-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531415#comment-16531415
]
Marcel Reutegger commented on OAK-7603:
---------------------------------------
I have a couple of suggestions, including one proposed by [~mduerig] in an
offline discussion (changing signature of
{{HttpBlobProvider.getHttpDownloadURL()}}. See my changes compared to the PR:
https://github.com/mattvryan/jackrabbit-oak/compare/direct-binary-access...mreutegg:direct-binary-access-oak-api
In summary:
- Move description for IllegalHttpUploadArgumentsException cases to
HttpBlobProvider.initiateHttpUpload(). I think this is the better place for the
description of when the exception will the thrown.
- Throw IllegalArgumentException when maxUploadSizeInBytes or maxNumberOfURLs
are not positive. I don't see a reason why the method should throw an
application specific exception in these cases.
- Change getHttpDownloadURL(String) to getHttpDownloadURL(Blob) for symetry
with completeHttpUpload().
- Removed InvalidHttpUploadTokenException. This exception is not used by
HttpBlobProvider nor HttpBlobUpload.
- Set the initial package export version to 1.0.0
One thing is still not clear to me. When does
{{HttpBlobProvider.initiateHttpUpload()}} return {{null}}? My guess is, when
the implementation cannot provide the functionality. If this is correct, then
this should be added to the JavaDoc as well.
> [DirectBinaryAccess][DISCUSS] Oak API extensions
> ------------------------------------------------
>
> Key: OAK-7603
> URL: https://issues.apache.org/jira/browse/OAK-7603
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: api
> Reporter: Marcel Reutegger
> Assignee: Matt Ryan
> Priority: Major
>
> Review and discuss the API extensions in oak-api. If desired these changes
> can be committed before the implementation is ready.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
