[
https://issues.apache.org/jira/browse/OAK-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539766#comment-16539766
]
Marcel Reutegger commented on OAK-7603:
---------------------------------------
A few more notes on the oak-api part of the pull request.
- {{HttpBlobProvider.completeHttpUpload(String)}} has a
{{IllegalArgumentException}} in the JavaDoc, but the method does not declare
throwing that exception. It's not required because it is a runtime exception,
but I still prefer the method declares it explicitly. WDYT?
- Shouldn't {{HttpBlobProvider}} and {{HttpBlobUpload}} have {{ProviderType}}
annotations?
Otherwise the oak-api changes look good to me and I'd like to commit them once
above two items have been addressed.
> [DirectBinaryAccess][DISCUSS] Oak API extensions
> ------------------------------------------------
>
> Key: OAK-7603
> URL: https://issues.apache.org/jira/browse/OAK-7603
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: api
> Reporter: Marcel Reutegger
> Assignee: Matt Ryan
> Priority: Major
>
> Review and discuss the API extensions in oak-api. If desired these changes
> can be committed before the implementation is ready.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
