[
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786100#comment-16786100
]
Vikas Saurabh commented on OAK-8111:
------------------------------------
[~reschke], I just meant that with the patch (and in context of dryRun)
* not giving {{--readOnly}} would default to read-only mode
* explicitly giving {{--readOnly}} arg also enables read-only mode
So, afaics, there's no way to enable read-write mode. So, we should either tie
read-only to dryRun (I don't see much value in readOnly mode in non-dry-run
mode) or we should probably have a read-write flag with recovery always going
to readOnly in default case (with/out dry-run).
Btw, read-write flag would also align with already existing flag that is used
for console command and hence would avoid some parameter bloat on part of
oak-run.
All that said, I'd prefer no extra flags require and overload dryRun to deduce
the read-only or read-write mode.
> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---------------------------------------------------------------
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: oak-run
> Reporter: Marcel Reutegger
> Assignee: Julian Reschke
> Priority: Minor
> Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore
> even when the dryRun flag is set. In dryRun mode, the command should create a
> read-only DocumentNodeStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
