[ 
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786509#comment-16786509
 ] 

Julian Reschke commented on OAK-8111:
-------------------------------------

bq. I like Vikas idea about creating the DocumentNodeStore in read-only mode by 
default and require a user to explicitly specify the read-write mode. This 
changes behaviour and basically means dryRun is ignored, but I think it may be 
worth it.

Yes, but should this be done in the context of this ticket?

bq. I would also make the --clusterId required. Just using an arbitrary 
available clusterId does not seem useful for the recovery command.

Why do you say "arbitrary"? With the current patch, when "dryRun" is specified, 
--clusterId de facto becomes required.

bq. As for the question what clusterIds are available, I suggest we create a 
separate command that lists the clusterIds, their state and additional 
information like lease end, etc.

We can split that off, but I'd still think that outputting the information  
automatically in this case is still a good idea.

> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---------------------------------------------------------------
>
>                 Key: OAK-8111
>                 URL: https://issues.apache.org/jira/browse/OAK-8111
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: oak-run
>            Reporter: Marcel Reutegger
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_10, candidate_oak_1_8
>             Fix For: 1.12
>
>         Attachments: OAK-8111.diff, OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore 
> even when the dryRun flag is set. In dryRun mode, the command should create a 
> read-only DocumentNodeStore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to