[
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786981#comment-16786981
]
Marcel Reutegger commented on OAK-8111:
---------------------------------------
A few comments:
The cast to DocumentNodeStore is unnecessary because the builder already
returns a DocumentNodeStore. I would also add the state close to the clusterId
in the list of clusterIds. This makes it more obvious which one can be used to
run the recovery. The command cannot run in read-write mode on an active
clusterId.
See my patch: [^OAK-8111-2.diff].
> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---------------------------------------------------------------
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: oak-run
> Reporter: Marcel Reutegger
> Assignee: Julian Reschke
> Priority: Minor
> Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111-2.diff, OAK-8111.diff, OAK-8111.diff,
> OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore
> even when the dryRun flag is set. In dryRun mode, the command should create a
> read-only DocumentNodeStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
