[
https://issues.apache.org/jira/browse/OAK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819875#comment-16819875
]
Alex Deparvu commented on OAK-8249:
-----------------------------------
I have updated the wip branch [0] based on feedback so far.
Added a new method to {{EffectiveNodeTypeProvider}} that takes an Iterable,
deprecated the old one (cannot remove it due to BC concerns).
And it turns out a lot of methods did not actually throw
{{RepositoryException}}, so I updated the signatures, making for a lot cleaner
code.
Didn't update the bench numbers as delta is in the same ballpark.
bq. doesn't that mean the current implementation of
EffectiveNodeTypeProvider.isNodeType(Tree, String) is incorrect then?
Yes I agree this looks fishy. Taking into consideration OAK-7652 and OAK-7997
this part might have been an oversight.
I will try to clarify this next but will create a dedicated issue to not mix
things too much.
[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-8249
> NodeImpl#isNodeType could load mixin info lazily
> ------------------------------------------------
>
> Key: OAK-8249
> URL: https://issues.apache.org/jira/browse/OAK-8249
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: jcr
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
> Priority: Minor
>
> The current isNodeType check loads both primary type and all mixins eagerly.
> I'm wondering how often is the case where someone only needs a primary type
> check, and if loading the mixins lazily would improve the throughput.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
