[ 
https://issues.apache.org/jira/browse/OAK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826921#comment-16826921
 ] 

Alex Deparvu commented on OAK-8249:
-----------------------------------

I restarted clean from trunk and focused on fixing the 
{{ReadOnlyNodeTypeManager}} directly. this is what I have [0].
It's a better approach, as we're fixing the core issue, but the code doesn't 
look too clean due to the awkwardness of providing the missing pieces to the 
{{ReadOnlyNodeTypeManager}} class. I'm curious to see if there's something I 
missed.

As I sidenote, I had to remove some optimisations because tests from 
ReadNodeTypeTest (OAK-3775) were failing [1]. It might actually be better to 
have a consistent behavior here, and the NodeImpl version is probably better.



[0] 
https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-8249-v2
[1] 
https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-8249-v2#diff-c48ef6caa98b019abda9bf4b5ec5a8e7L257

> NodeImpl#isNodeType could load mixin info lazily
> ------------------------------------------------
>
>                 Key: OAK-8249
>                 URL: https://issues.apache.org/jira/browse/OAK-8249
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, core-spi, jcr
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Minor
>
> The current isNodeType check loads both primary type and all mixins eagerly.
> I'm wondering how often is the case where someone only needs a primary type 
> check, and if loading the mixins lazily would improve the throughput.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to