[ 
https://issues.apache.org/jira/browse/OAK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825800#comment-16825800
 ] 

Marcel Reutegger commented on OAK-8249:
---------------------------------------

bq. create a dedicated issue to not mix things too much

I understand, but then switching over to a correctly implemented 
{{EffectiveNodeTypeProvider.isNodeType(Tree, String)}} would allow us to keep 
the current EffectiveNodeTypeProvider interface as is.

On the changes you propose on GitHub. They look good to me. I was only 
wondering about the new method on {{EffectiveNodeTypeProvider}} from a 
compatibility perspective. Wouldn't it be better to have a default 
implementation for the new method? But then, all implementations are probably 
in Oak anyway and your proposal is less effort to migrate to.

> NodeImpl#isNodeType could load mixin info lazily
> ------------------------------------------------
>
>                 Key: OAK-8249
>                 URL: https://issues.apache.org/jira/browse/OAK-8249
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, core-spi, jcr
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Minor
>
> The current isNodeType check loads both primary type and all mixins eagerly.
> I'm wondering how often is the case where someone only needs a primary type 
> check, and if loading the mixins lazily would improve the throughput.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to